zachjsh commented on code in PR #15469:
URL: https://github.com/apache/druid/pull/15469#discussion_r1418470458
##########
extensions-core/druid-catalog/src/main/java/org/apache/druid/catalog/sync/CatalogClient.java:
##########
@@ -86,7 +86,7 @@ public CatalogClient(
@Override
public List<TableMetadata> tablesForSchema(String dbSchema)
{
- String url = StringUtils.replace(SCHEMA_SYNC_PATH, "{dbSchema}", dbSchema);
+ String url = StringUtils.replace(SCHEMA_SYNC_PATH, "{schema}", dbSchema);
Review Comment:
nit: Good catch. should we move `"{schema}"` to a constant here?
##########
extensions-core/druid-catalog/src/main/java/org/apache/druid/catalog/sync/CatalogClient.java:
##########
@@ -96,7 +96,7 @@ public List<TableMetadata> tablesForSchema(String dbSchema)
@Override
public TableMetadata table(TableId id)
{
- String url = StringUtils.replace(TABLE_SYNC_PATH, "{dbSchema}",
id.schema());
+ String url = StringUtils.replace(TABLE_SYNC_PATH, "{schema}", id.schema());
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
