kfaraz commented on PR #15557: URL: https://github.com/apache/druid/pull/15557#issuecomment-1857192079
Thanks for the response, @TestBoost . - Since all the changes seem small and are in the same vein, it would be better to have a single PR that is updating all the tests in a single module (e.g. the module touched in this PR is `server`), if not the entire Druid project. - It would be nice to know what is the overall time benefit that you are gaining by these changes. - For the current PR in particular, it makes sense for `derbyConnectorRule` and `jsonMapper` to be static but not the the test target `sqlSegmentsMetadataManager` as we explicitly want it to be freshly created in every test. This is true even when the metadata manager state doesn't seem to be altered in a particular test. - For #15533, I have left a comment on that PR itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
