kfaraz commented on PR #15418: URL: https://github.com/apache/druid/pull/15418#issuecomment-1886347338
Have all of these tests been reported as flaky? I am not sure if that is really the case. These changes seem to be using sets instead of lists in a lot of places and changing equality assertions of json strings to JsonNode objects. Are these changes really needed? If there is indeed a flaky test, please share links in the PR description to one or more builds where these tests actually failed. For cases where there is a flake, we should try to figure out exactly what is causing the flakiness and update tests only when we fully understand the intent of the original test. cc: @yashdeep97 , @cryptoe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
