gianm opened a new pull request, #15680: URL: https://github.com/apache/druid/pull/15680
Useful for two reasons. First, we don't need to recompute the key set on every call to `keySet()`, `size()`, etc. Second, because when dimension discovery is *not* enabled, the parser requests the key set but does not call any methods on it. When the key set is lazy, we can avoid computing it entirely. Benchmarks: ``` Benchmark Mode Cnt Score Error Units JsonLineReaderBenchmark.baseline avgt 5 2055.294 ± 28.688 us/op [before] JsonLineReaderBenchmark.baseline avgt 25 1755.839 ± 4.062 us/op [after] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
