LakshSingla commented on code in PR #15869:
URL: https://github.com/apache/druid/pull/15869#discussion_r1482844384
##########
sql/src/main/java/org/apache/druid/sql/http/ResultFormat.java:
##########
@@ -133,7 +134,10 @@ public interface Writer extends Closeable
void writeHeader(RelDataType rowType, boolean includeTypes, boolean
includeSqlTypes) throws IOException;
- void writeHeaderFromRowSignature(RowSignature rowSignature, boolean
includeTypes) throws IOException;
+ default void writeHeaderFromRowSignature(RowSignature rowSignature,
boolean includeTypes) throws IOException
Review Comment:
Also, a better default implementation would be deferring the call to
`writeHeader`, after constructing a `RelDataType` from `rowType`. The types
should be omitted since that would be ambiguous (a single `ColumnType` can to
multiple `RelDataType`).
However, as per the previous comment, I am in favor of removing the default
implementation altogether and leaving it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
