abhishekrb19 opened a new pull request, #15898: URL: https://github.com/apache/druid/pull/15898
This patch addresses thereview comment by adding javadocs for the new unit tests: https://github.com/apache/druid/pull/15878#issuecomment-1939129684. Also, while doing this, I noticed that the `KafkaEmitterTest#testAllEventsWithCommonTopic` sometimes flakes. It's easy to reproduce the flakiness in IntelliJ using the "Run the test until failure" feature. The fix is in https://github.com/apache/druid/commit/a88369c68bea144895670ffe417d4818c60cceb7 - the producer callback can trigger concurrently and override the map initialization. This PR has: - [x] been self-reviewed. - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. (https://github.com/apache/druid/blob/master/dev/license.md) - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
