rash67 commented on PR #15686: URL: https://github.com/apache/druid/pull/15686#issuecomment-1944935456
this works from within github actions scripts? there will be a java-util directory? (finding the java binary) On Wed, Feb 14, 2024 at 2:43 PM Xavier Léauté ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In .github/scripts/setup_test_profiling_env.sh > <https://github.com/apache/druid/pull/15686#discussion_r1490154934>: > > > then > curl https://static.imply.io/cp/$JAR_INPUT_FILE -s -o $JAR_OUTPUT_FILE > > + # Run 'java -version' and capture the output > + output=$(java -version 2>&1) > + > + # Extract the version number using grep and awk > + jvm_version=$(echo "$output" | grep "version" | awk -F '"' '{print $2}') > > depending on the JVM implementation this might not give us what we want. > I'd recommend using the code that's already been tested here > > > https://github.com/apache/druid/blob/c324e377512bfa815e0e71fc3dbdb69934d9951e/examples/bin/run-java#L27 > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/druid/pull/15686#pullrequestreview-1881443440>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAOTWP4OLAP5KST62MC5MLYTU4ZVAVCNFSM6AAAAABB34F4TWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOBRGQ2DGNBUGA> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- Sam Rash ***@***.*** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
