abhishekrb19 commented on code in PR #15941:
URL: https://github.com/apache/druid/pull/15941#discussion_r1500195745
##########
server/src/test/java/org/apache/druid/server/coordinator/simulate/TestSegmentsMetadataManager.java:
##########
@@ -34,33 +36,69 @@
import org.joda.time.Interval;
import javax.annotation.Nullable;
+import java.util.ArrayList;
import java.util.Collection;
+import java.util.Comparator;
import java.util.List;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
+import java.util.stream.Collectors;
public class TestSegmentsMetadataManager implements SegmentsMetadataManager
{
+ private static final Logger log = new
Logger(TestSegmentsMetadataManager.class);
+
+ /**
+ * segments = usedSegments + unusedSegments. Tracking unusedSegments
separately for convenience and
+ * additional metadata.
+ */
private final ConcurrentMap<String, DataSegment> segments = new
ConcurrentHashMap<>();
private final ConcurrentMap<String, DataSegment> usedSegments = new
ConcurrentHashMap<>();
+ private final ConcurrentMap<String, DataSegmentPlus> unusedSegments = new
ConcurrentHashMap<>();
private volatile DataSourcesSnapshot snapshot;
- public void addSegment(DataSegment segment)
+ /**
+ * Adds the used segment.
+ */
+ public void addSegment(DataSegment segment, boolean isUsed)
Review Comment:
Removed it, I was trying to consolidate some of the methods, but decided to
just keep them separate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
