LakshSingla opened a new pull request, #15987:
URL: https://github.com/apache/druid/pull/15987
### Description
While converting `Sequence<ScanResultValue>` to `Sequence<Frames>`, when
`maxSubqueryBytes` is enabled, we batch the results to prevent creating a
single frame per `ScanResultValue.` Batching requires peeking into the actual
value, and checking if the row signature of the scan result’s value matches
that of the previous value.
Since we can do this indefinitely (in the worst case all of them have the
same signature), we keep fetching them and accumulating them in a list (on the
heap). We don’t really know how much to batch before we actually write the
value as frames.
The PR modifies the batching logic to not accumulate the results in an
intermediary list.
(It is a draft PR since the code requires a lot of testing for the edge
cases).
<hr>
##### Key changed/added classes in this PR
* `MyFoo`
* `OurBar`
* `TheirBaz`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
