georgew5656 commented on code in PR #16008:
URL: https://github.com/apache/druid/pull/16008#discussion_r1509268882
##########
extensions-contrib/kubernetes-overlord-extensions/src/test/java/org/apache/druid/k8s/overlord/taskadapter/K8sTaskAdapterTest.java:
##########
@@ -572,14 +576,72 @@ void testEphemeralStorageIsRespected() throws IOException
Assertions.assertEquals(expected, actual);
}
+ @Test
+ void testEphemeralResourceIsEspected() throws IOException
Review Comment:
i think this test name is wrong, seems like it should be more like
testCPUResourceIsRespected
##########
docs/development/extensions-contrib/k8s-jobs.md:
##########
@@ -219,23 +219,24 @@ data:
```
### Properties
-|Property| Possible Values | Description
|Default|required|
-|--------|-----------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-------|--------|
-|`druid.indexer.runner.debugJobs`| `boolean` | Clean up K8s jobs after
tasks complete.
|False|No|
-|`druid.indexer.runner.sidecarSupport`| `boolean` | Deprecated, specify
adapter type as runtime property `druid.indexer.runner.k8s.adapter.type:
overlordMultiContainer` instead. If your overlord pod has sidecars, this will
attempt to start the task with the same sidecars as the overlord pod. |False|No|
-|`druid.indexer.runner.primaryContainerName`| `String` | If running
with sidecars, the `primaryContainerName` should be that of your druid
container like `druid-overlord`.
|First container in `podSpec` list|No|
-|`druid.indexer.runner.kubexitImage`| `String` | Used kubexit project
to help shutdown sidecars when the main pod completes. Otherwise jobs with
sidecars never terminate.
|karlkfi/kubexit:latest|No|
-|`druid.indexer.runner.disableClientProxy`| `boolean` | Use this if you
have a global http(s) proxy and you wish to bypass it.
|false|No|
-|`druid.indexer.runner.maxTaskDuration`| `Duration` | Max time a task is
allowed to run for before getting killed
|`PT4H`|No|
-|`druid.indexer.runner.taskCleanupDelay`| `Duration` | How long do jobs
stay around before getting reaped from K8s
|`P2D`|No|
-|`druid.indexer.runner.taskCleanupInterval`| `Duration` | How often to
check for jobs to be reaped
|`PT10M`|No|
-|`druid.indexer.runner.K8sjobLaunchTimeout`| `Duration` | How long to
wait to launch a K8s task before marking it as failed, on a resource
constrained cluster it may take some time.
|`PT1H`|No|
-|`druid.indexer.runner.javaOptsArray`| `JsonArray` | java opts for the
task.
|`-Xmx1g`|No|
-|`druid.indexer.runner.labels`| `JsonObject` | Additional labels you want
to add to peon pod
|`{}`|No|
-|`druid.indexer.runner.annotations`| `JsonObject` | Additional annotations
you want to add to peon pod
|`{}`|No|
-|`druid.indexer.runner.peonMonitors`| `JsonArray` | Overrides
`druid.monitoring.monitors`. Use this property if you don't want to inherit
monitors from the Overlord.
|`[]`|No|
-|`druid.indexer.runner.graceTerminationPeriodSeconds`| `Long` |
Number of seconds you want to wait after a sigterm for container lifecycle
hooks to complete. Keep at a smaller value if you want tasks to hold locks for
shorter periods.
|`PT30S` (K8s default)|No|
-|`druid.indexer.runner.capacity`| `Integer` | Number of concurrent jobs
that can be sent to Kubernetes.
|`2147483647`|No|
Review Comment:
can you use the intellij props from here so the whole table doesn't get
replaced like this?
https://github.com/apache/druid/blob/master/dev/druid_intellij_formatting.xml#L77-L80
intellij config instructions:
https://github.com/apache/druid/blob/master/dev/intellij-setup.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
