abhishekrb19 commented on code in PR #16141:
URL: https://github.com/apache/druid/pull/16141#discussion_r1527055007
##########
server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManager.java:
##########
@@ -53,7 +53,20 @@ public interface SegmentsMetadataManager
*/
int markAsUsedAllNonOvershadowedSegmentsInDataSource(String dataSource);
- int markAsUsedNonOvershadowedSegmentsInInterval(String dataSource, Interval
interval);
+ /**
+ * Marks non-overshadowed unused segments for the given interval as used.
+ * @return Number of segments updated
+ */
+ default int markAsUsedNonOvershadowedSegmentsInInterval(String dataSource,
Interval interval)
Review Comment:
This default interface method is only used by tests. Should we just remove
it in favor of the three argument counterpart? Same for
`markAsUsedNonOvershadowedSegmentsInInterval`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
