AmatyaAvadhanula commented on code in PR #16144:
URL: https://github.com/apache/druid/pull/16144#discussion_r1556804106


##########
server/src/main/java/org/apache/druid/indexing/overlord/IndexerMetadataStorageCoordinator.java:
##########
@@ -237,7 +238,7 @@ Map<SegmentCreateRequest, SegmentIdWithShardSpec> 
allocatePendingSegments(
    *                                identifier may have a version lower than 
this one, but will not have one higher.
    * @param skipSegmentLineageCheck if true, perform lineage validation using 
previousSegmentId for this sequence.
    *                                Should be set to false if replica tasks 
would index events in same order
-   *
+   * @param taskGroup

Review Comment:
   Added description



##########
server/src/main/java/org/apache/druid/indexing/overlord/IndexerMetadataStorageCoordinator.java:
##########
@@ -475,4 +476,8 @@ SegmentPublishResult commitMetadataOnly(
    * @return number of deleted entries from the metadata store
    */
   int deleteUpgradeSegmentsForTask(String taskId);
+
+  int deletePendingSegmentsForTaskGroup(String taskGroup);

Review Comment:
   Added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to