Akshat-Jain opened a new pull request, #16328: URL: https://github.com/apache/druid/pull/16328
### Description This PR adds support for loading a specified subset of lookups in the task layer. It updates the `LookupReferencesManager` to support 3 modes: 1. Load all the lookups if `lookupsToLoad` method param is null. 2. Don't load any lookups if `lookupsToLoad` method param is empty list. 3. Load only the specified lookups if `lookupsToLoad` method param is non-empty list containing the lookup names to load. This PR also updates the `KillUnusedSegmentsTask` to return an empty list of lookups to load, as this task has no dependency on any lookups. Future work would involve implementing this functionality for other tasks, depending on their dependency on lookups. ### Test plan 1. I did some manual testing which involved running `KillUnusedSegmentsTask` with different implementations of `getLookupsToLoad()` method, to test the behavior of all the 3 aforementioned modes. 2. Added or updated unit tests to validate the changed functionality. This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
