kfaraz commented on code in PR #16328:
URL: https://github.com/apache/druid/pull/16328#discussion_r1579153761
##########
services/src/main/java/org/apache/druid/cli/CliPeon.java:
##########
@@ -356,6 +356,14 @@ public String getTaskIDFromTask(final Task task)
{
return task.getId();
}
+
+ @Provides
+ @LazySingleton
+ @Named(DataSourceTaskIdHolder.LOOKUPS_TO_LOAD_FOR_TASK)
+ public List<String> getLookupsToLoad(final Task task)
Review Comment:
Indexer is a single process, so it should always load all lookups, right?
IIUC, the changes here would only bind the `lookupsToLoad` for peons, which is
what we want.
Not too sure about MM-less system. The other PR had tweaked `K8sTaskAdapter`
to handle it there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
