Akshat-Jain commented on code in PR #16328:
URL: https://github.com/apache/druid/pull/16328#discussion_r1581724648
##########
server/src/main/java/org/apache/druid/query/lookup/LookupReferencesManager.java:
##########
@@ -373,9 +376,24 @@ private void takeSnapshot(Map<String,
LookupExtractorFactoryContainer> lookupMap
}
}
- private void loadAllLookupsAndInitStateRef()
+ /**
+ * Load a set of lookups based on the injected value in {@link
DataSourceTaskIdHolder#getLookupLoadingSpec()}.
+ */
+ private void loadLookupsAndInitStateRef()
{
- List<LookupBean> lookupBeanList = getLookupsList();
+ LookupLoadingSpec lookupLoadingSpec =
lookupListeningAnnouncerConfig.getLookupLoadingSpec();
+ List<LookupBean> lookupBeanList;
+ if (lookupLoadingSpec.getLookupLoadingMode() ==
LookupLoadingSpec.LookupLoadingMode.NONE) {
+ lookupBeanList = Collections.emptyList();
Review Comment:
Makes sense.
I'll keep it as empty list to keep things easier to understand, and update
the next if-else to:
```
if (lookupBeanList != null && !lookupBeanList.isEmpty()) {
startLookups(lookupBeanList);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
