kfaraz commented on code in PR #16512:
URL: https://github.com/apache/druid/pull/16512#discussion_r1622228853
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java:
##########
@@ -1018,4 +1022,37 @@ List<Task> getTasks()
giant.unlock();
}
}
+
+ void validateTaskPayload(Task task)
+ {
+ try {
+ String payload = passwordRedactingMapper.writeValueAsString(task);
+ if (payload.length() > TASK_SIZE_WARNING_THRESHOLD) {
+ log.warn("Received a large task payload [%s] with id [%s] and
datasource [%s]" +
+ " There may be downstream issues caused by managing this large
payload." +
Review Comment:
Also, should we continue to warn if someone has explicitly set the
`maxTaskPayloadSize` to be larger than the `TASK_SIZE_WARNING_THRESHOLD`? I
guess it makes sense to always give out a warning to encourage users/operators
to reduce the task payload sizes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
