amaechler commented on code in PR #16521: URL: https://github.com/apache/druid/pull/16521#discussion_r1622494550
########## extensions-core/azure-extensions/src/test/java/org/apache/druid/data/input/azure/AzureEntityTest.java: ########## @@ -28,14 +28,16 @@ import org.apache.druid.storage.azure.AzureUtils; import org.easymock.EasyMock; import org.easymock.EasyMockSupport; -import org.junit.Assert; -import org.junit.Before; -import org.junit.Test; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; import java.io.IOException; import java.io.InputStream; import java.net.URI; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertSame; Review Comment: Would it be worth starting to use it more, at least in tests? I tried to look through the codebase a bit: it seems like there are sporadic usages of it, but as you said, there isn't a consistent style (say specifically for assertions). I feel the assertions read a bit more concisely this way. But I'm also happy to use a non-static import and prefix the assertion functions with the `Assertions` package name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
