georgew5656 commented on code in PR #16510:
URL: https://github.com/apache/druid/pull/16510#discussion_r1626113399
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/KubernetesPeonClient.java:
##########
@@ -274,6 +279,14 @@ private void emitK8sPodMetrics(Task task, String metric,
long durationMs)
{
ServiceMetricEvent.Builder metricBuilder = new
ServiceMetricEvent.Builder();
IndexTaskUtils.setTaskDimensions(metricBuilder, task);
+ ExecutionConfig executionConfig = executionConfigRef.get();
+ if (executionConfig != null && executionConfig.getBehaviorStrategy() !=
null) {
Review Comment:
would this ever actually be null? with the default can't we set a @Nonnull
flag on it and assume it'll be there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
