Akshat-Jain commented on PR #16606: URL: https://github.com/apache/druid/pull/16606#issuecomment-2172412274
> Does it mean that when the server is disconnected, the inner input stream is working fine (and returning partial data), however the wrapping GZ stream is throwing because the data is incomplete? If so, why is the inner retrying stream not throwing an error and retrying on server disconnection? No, the inner stream stops working. But since the inner stream isn't `RetryingInputStream` but rather a wrapper over `RetryingInputStream`, it loses the retries where we create a new input stream and start using that. Previously: `GZIPInputStream(FilterInputStream(RetryingInputStream))` Now: `RetryingGZIPInputStream(GZIPInputStream(FilterInputStream(RetryingInputStream)))` > Where are these other streams getting created? In the code that I added above (`return new BZip2CompressorInputStream(in, true);`, `return new XZCompressorInputStream(in, true);`, etc). Link to the method in the code: https://github.com/apache/druid/blob/d6c7d868cdb450c2d2064d324b3da124d2a491b6/processing/src/main/java/org/apache/druid/utils/CompressionUtils.java#L620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
