github-advanced-security[bot] commented on code in PR #16724: URL: https://github.com/apache/druid/pull/16724#discussion_r1673667539
########## processing/src/main/java/org/apache/druid/extendedset/intset/IntSet.java: ########## @@ -1,100 +1,100 @@ -/* - * (c) 2010 Alessandro Colantonio - * <mailto:colan...@mat.uniroma3.it> - * <http://ricerca.mat.uniroma3.it/users/colanton> - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.apache.druid.extendedset.intset; - - -import java.util.Iterator; -import java.util.NoSuchElementException; - -/** - * @version $Id: IntSet.java 135 2011-01-04 15:54:48Z cocciasik $ - */ -public interface IntSet extends Cloneable, Comparable<IntSet> -{ - - /** - * See the <code>clone()</code> of {@link Object} - * - * @return cloned object - */ - IntSet clone(); - - /** - * @return a {@link IntIterator} instance to iterate over the set - */ - IntIterator iterator(); - - /** - * @return a {@link IntIterator} instance to iterate over the set in - * descending order - */ - IntIterator descendingIterator(); - - /** - * @return the number of elements in this set (its cardinality) - */ - int size(); - - /** - * @return <tt>true</tt> if this set contains no elements - */ - boolean isEmpty(); - - /** - * An {@link Iterator}-like interface that allows to "skip" some elements of - * the set - */ - interface IntIterator extends org.roaringbitmap.IntIterator - { - /** - * @return <tt>true</tt> if the iterator has more elements. - */ - @Override - boolean hasNext(); - - /** - * @return the next element in the iteration. - * - * @throws NoSuchElementException iteration has no more elements. - */ - @Override - int next(); - - /** - * Skips all the elements before the specified element, so that - * {@link #next()} gives the given element or, if it does not exist, the - * element immediately after according to the sorting provided by this - * set. - * <p> - * If <code>element</code> is less than the next element, it does - * nothing - * - * @param element first element to not skip - */ - void skipAllBefore(int element); - - /** - * Clone the iterator - * - * @return a clone of the IntIterator - */ - @Override - IntIterator clone(); - } -} +/* + * (c) 2010 Alessandro Colantonio + * <mailto:colan...@mat.uniroma3.it> + * <http://ricerca.mat.uniroma3.it/users/colanton> + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.druid.extendedset.intset; + + +import java.util.Iterator; +import java.util.NoSuchElementException; + +/** + * @version $Id: IntSet.java 135 2011-01-04 15:54:48Z cocciasik $ + */ +public interface IntSet extends Cloneable, Comparable<IntSet> +{ + + /** + * See the <code>clone()</code> of {@link Object} + * + * @return cloned object + */ + IntSet clone(); Review Comment: ## Missing Override annotation This method overrides [Object.clone](1); it is advisable to add an Override annotation. [Show more details](https://github.com/apache/druid/security/code-scanning/3719) ########## processing/src/main/java/org/apache/druid/extendedset/intset/IntSet.java: ########## @@ -1,100 +1,100 @@ -/* - * (c) 2010 Alessandro Colantonio - * <mailto:colan...@mat.uniroma3.it> - * <http://ricerca.mat.uniroma3.it/users/colanton> - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.apache.druid.extendedset.intset; - - -import java.util.Iterator; -import java.util.NoSuchElementException; - -/** - * @version $Id: IntSet.java 135 2011-01-04 15:54:48Z cocciasik $ - */ -public interface IntSet extends Cloneable, Comparable<IntSet> -{ - - /** - * See the <code>clone()</code> of {@link Object} - * - * @return cloned object - */ - IntSet clone(); - - /** - * @return a {@link IntIterator} instance to iterate over the set - */ - IntIterator iterator(); - - /** - * @return a {@link IntIterator} instance to iterate over the set in - * descending order - */ - IntIterator descendingIterator(); - - /** - * @return the number of elements in this set (its cardinality) - */ - int size(); - - /** - * @return <tt>true</tt> if this set contains no elements - */ - boolean isEmpty(); - - /** - * An {@link Iterator}-like interface that allows to "skip" some elements of - * the set - */ - interface IntIterator extends org.roaringbitmap.IntIterator - { - /** - * @return <tt>true</tt> if the iterator has more elements. - */ - @Override - boolean hasNext(); - - /** - * @return the next element in the iteration. - * - * @throws NoSuchElementException iteration has no more elements. - */ - @Override - int next(); - - /** - * Skips all the elements before the specified element, so that - * {@link #next()} gives the given element or, if it does not exist, the - * element immediately after according to the sorting provided by this - * set. - * <p> - * If <code>element</code> is less than the next element, it does - * nothing - * - * @param element first element to not skip - */ - void skipAllBefore(int element); - - /** - * Clone the iterator - * - * @return a clone of the IntIterator - */ - @Override - IntIterator clone(); - } -} +/* + * (c) 2010 Alessandro Colantonio + * <mailto:colan...@mat.uniroma3.it> + * <http://ricerca.mat.uniroma3.it/users/colanton> + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.druid.extendedset.intset; + + +import java.util.Iterator; +import java.util.NoSuchElementException; + +/** + * @version $Id: IntSet.java 135 2011-01-04 15:54:48Z cocciasik $ + */ +public interface IntSet extends Cloneable, Comparable<IntSet> +{ + + /** + * See the <code>clone()</code> of {@link Object} + * + * @return cloned object + */ + IntSet clone(); + + /** + * @return a {@link IntIterator} instance to iterate over the set + */ + IntIterator iterator(); + + /** + * @return a {@link IntIterator} instance to iterate over the set in + * descending order + */ + IntIterator descendingIterator(); + + /** + * @return the number of elements in this set (its cardinality) + */ + int size(); + + /** + * @return <tt>true</tt> if this set contains no elements + */ + boolean isEmpty(); + + /** + * An {@link Iterator}-like interface that allows to "skip" some elements of + * the set + */ + interface IntIterator extends org.roaringbitmap.IntIterator Review Comment: ## Class has same name as super class IntIterator has the same name as its supertype [org.roaringbitmap.IntIterator](1). [Show more details](https://github.com/apache/druid/security/code-scanning/4084) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
