jgoz commented on code in PR #16756:
URL: https://github.com/apache/druid/pull/16756#discussion_r1683514410
##########
web-console/src/components/segment-timeline/segment-timeline.tsx:
##########
@@ -236,17 +241,15 @@ ORDER BY "start" DESC`;
}
private readonly dataQueryManager: QueryManager<
- { capabilities: Capabilities; startDate: Date; endDate: Date },
+ { capabilities: Capabilities; dateRange: NonNullDateRange },
any
>;
private readonly chartMargin = { top: 40, right: 15, bottom: 20, left: 60 };
constructor(props: SegmentTimelineProps) {
super(props);
- const startDate = ceilToUtcDay(new Date());
- const endDate = new Date(startDate.valueOf());
- startDate.setUTCMonth(startDate.getUTCMonth() - DEFAULT_TIME_SPAN_MONTHS);
+ const dateRange = getDefautlDateRange();
Review Comment:
```suggestion
const dateRange = getDefaultDateRange();
```
##########
web-console/src/components/segment-timeline/segment-timeline.tsx:
##########
@@ -87,6 +85,13 @@ interface IntervalRow {
const DEFAULT_TIME_SPAN_MONTHS = 3;
+function getDefautlDateRange(): NonNullDateRange {
Review Comment:
Nit
```suggestion
function getDefaultDateRange(): NonNullDateRange {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
