clintropolis commented on code in PR #16758:
URL: https://github.com/apache/druid/pull/16758#discussion_r1684208108
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java:
##########
@@ -1155,18 +1139,9 @@ public IndexIOConfig(
// old constructor for backward compatibility
@Deprecated
- public IndexIOConfig(FirehoseFactory firehoseFactory, @Nullable Boolean
appendToExisting, @Nullable Boolean dropExisting)
- {
- this(firehoseFactory, null, null, appendToExisting, dropExisting);
- }
-
- @Nullable
- @JsonProperty("firehose")
- @JsonInclude(Include.NON_NULL)
- @Deprecated
- public FirehoseFactory getFirehoseFactory()
+ public IndexIOConfig(@Nullable Boolean appendToExisting, @Nullable Boolean
dropExisting)
Review Comment:
good catch, removed
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexIOConfig.java:
##########
@@ -37,26 +36,25 @@ public class ParallelIndexIOConfig extends IndexIOConfig
{
@JsonCreator
public ParallelIndexIOConfig(
- @JsonProperty("firehose") @Nullable FirehoseFactory firehoseFactory,
@JsonProperty("inputSource") @Nullable InputSource inputSource,
@JsonProperty("inputFormat") @Nullable InputFormat inputFormat,
@JsonProperty("appendToExisting") @Nullable Boolean appendToExisting,
@JsonProperty("dropExisting") @Nullable Boolean dropExisting
)
{
- super(firehoseFactory, inputSource, inputFormat, appendToExisting,
dropExisting);
+ super(inputSource, inputFormat, appendToExisting, dropExisting);
}
// old constructor for backward compatibility
@Deprecated
- public ParallelIndexIOConfig(FirehoseFactory firehoseFactory, @Nullable
Boolean appendToExisting)
+ public ParallelIndexIOConfig(@Nullable Boolean appendToExisting)
{
- this(firehoseFactory, null, null, appendToExisting, null);
+ this(null, null, appendToExisting, null);
}
@Deprecated
- public ParallelIndexIOConfig(FirehoseFactory firehoseFactory, @Nullable
Boolean appendToExisting, boolean dropExisting)
+ public ParallelIndexIOConfig(@Nullable Boolean appendToExisting, boolean
dropExisting)
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
