kgyrtkirk commented on code in PR #16708:
URL: https://github.com/apache/druid/pull/16708#discussion_r1686178374
##########
processing/src/main/java/org/apache/druid/error/DruidException.java:
##########
@@ -467,14 +470,27 @@ public DruidException build(String formatMe, Object...
vals)
public DruidException build(Throwable cause, String formatMe, Object...
vals)
{
- return new DruidException(
+ final DruidException retVal = new DruidException(
cause,
errorCode,
targetPersona,
category,
StringUtils.nonStrictFormat(formatMe, vals),
deserialized
);
+
+ StackTraceElement[] stackTrace = retVal.getStackTrace();
+ int firstNonDruidExceptionIndex = 0;
+ while (
+ firstNonDruidExceptionIndex < stackTrace.length &&
+
stackTrace[firstNonDruidExceptionIndex].getClassName().startsWith(CLASS_NAME_STR))
{
+ ++firstNonDruidExceptionIndex;
+ }
+ if (firstNonDruidExceptionIndex < stackTrace.length) {
+ retVal.setStackTrace(Arrays.copyOfRange(stackTrace,
firstNonDruidExceptionIndex, stackTrace.length));
Review Comment:
this conditional looks odd... its not wrong; but it will only skip the set
if it went over the full stacktrace; but when its `0` it still does it...
I guess the intention here is to clip the exception construction process?
could you add a test for this?
with a case which checks what happens if a `DruidException` is set as a
cause for another `DruidException`
##########
processing/src/main/java/org/apache/druid/error/NotYetImplemented.java:
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.error;
+
+/**
+ * A failure class that is used to indicate that something is just not
implemented yet. This is useful when a
+ * developer builds something and they intentionally do not implement a
specific branch of code or type of object.
+ * <p>
+ * The lack of implementation is not necessarily a statement that it SHOULDN'T
be implemented, it's just an indication
+ * that it has not YET been implemented. When one of these exceptions is
seen, it is usually an indication that it is
+ * now time to actually implement the path that was previously elided.
+ * <p>
+ * Often times, the code path wasn't implemented because the developer thought
that it wasn't actually possible to
+ * see it executed. So, collecting and providing information about why the
particular path got executed is often
+ * extremely helpful in understanding why it happened and accelerating the
implementation of what the correct behavior
+ * should be.
+ */
+public class NotYetImplemented extends DruidException.Failure
+{
+ public static DruidException ex(String msg, Object... args)
Review Comment:
I think it would be better to not have factory methods which omit the cause
exception
I've seen places where there was a `catch` block - but the newly created
exception did not had the `cause` filled in most likely by mistake - but as a
result the stacktrace was clipped.
I think forcing the api user to write out `null` for cause makes this
mistake less probable to do the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
