kgyrtkirk commented on code in PR #16738: URL: https://github.com/apache/druid/pull/16738#discussion_r1686339981
########## processing/src/main/java/org/apache/druid/query/rowsandcols/ArrayListRowsAndColumns.java: ########## @@ -212,15 +212,14 @@ public <T> T as(Class<T> clazz) @Override public void addColumn(String name, Column column) { - if (rows.size() == numRows()) { + if (rows.size() == numRows() && column instanceof ObjectArrayColumn) { Review Comment: maybe `column.as(ColumnValueSwapper.class) != null` would be less confining -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org