jakubmatyszewski opened a new issue, #16771: URL: https://github.com/apache/druid/issues/16771
### Affected Version 29.0.1 ### Description I've noticed that metric `taskSlot/idle/count` that is part of `TaskSlotCountStatsMonitor` is not excluding slots from disabled workers. I'm running overlord in httpRemote mode and it seems like this metric should account for it - it calls for [getWorkersEligibleToRunTasks()](https://github.com/apache/druid/blob/15b3efd085d3e69417a00d06b04e325fd26e729a/indexing-service/src/main/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunner.java#L1728) which checks if the worker [isEnabled()](https://github.com/apache/druid/blob/15b3efd085d3e69417a00d06b04e325fd26e729a/indexing-service/src/main/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunner.java#L375), but then when I connect to the middlemanager instance I get: ``` $ curl -X POST localhost:8091/druid/worker/v1/disable {"druid-middlemanager-default-0.druid-middlemanager.druid-test.svc.cluster.local:8091":"disabled"} $ curl -s localhost:8000/metrics | grep slot | grep .0 druid_middlemanager_worker_taskslot_total_count{category="__default_worker_category_",druid_service="druid/middleManager",} 3.0 druid_middlemanager_worker_taskslot_used_count{category="__default_worker_category_",druid_service="druid/middleManager",} 0.0 druid_middlemanager_worker_taskslot_idle_count{category="__default_worker_category_",druid_service="druid/middleManager",} 3.0 ```  So in the end I'm kinda confused why the metric doesn't show proper value - I guess I'm missing something while reading the code..? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
