gargvishesh commented on code in PR #16778: URL: https://github.com/apache/druid/pull/16778#discussion_r1687477999
########## indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java: ########## @@ -671,7 +671,10 @@ private static DataSchema createDataSchema( finalDimensionsSpec, finalMetricsSpec, uniformGranularitySpec, - transformSpec == null ? null : new TransformSpec(transformSpec.getFilter(), null) + transformSpec == null ? null : new TransformSpec(transformSpec.getFilter(), null), + existingSegmentAnalyzer.getHasRolledUpSegments(), + null, + null Review Comment: It was passed as `null` even earlier, so this is just refactoring. But if you think we should still pass non-null -- which does make sense -- then I can update it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org