sreemanamala commented on code in PR #16780:
URL: https://github.com/apache/druid/pull/16780#discussion_r1687594201
##########
sql/src/test/resources/drill/window/queries/druid_queries/partition_by_array/wikipedia_query_1.q:
##########
@@ -0,0 +1,6 @@
+select
+countryName, cityName, channel,
+row_number() over (partition by array[1,2,length(cityName)] order by
countryName) as c
Review Comment:
`partition by array[1,2,length(cityName)]` is same as `partition by
length(cityName)`.
To provide the difference may be can we try out `partition by array[1,
expr1, expr2]`?
##########
sql/src/test/resources/drill/window/queries/druid_queries/partition_by_array/wikipedia_query_2.q:
##########
@@ -0,0 +1,6 @@
+select
+countryName, cityName, channel,
+row_number() over (partition by array[1,2,3] order by countryName) as c
+from wikipedia
+where countryName in ('Austria', 'Republic of Korea')
+group by countryName, cityName, channel
Review Comment:
dont think this test adds much of a value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
