clintropolis opened a new pull request, #16789: URL: https://github.com/apache/druid/pull/16789
### Description The validation added in #15920 should make this relatively safe to do. Some ingestions that are based on the old 'mvd' mode syntax which implicitly changed `ARRAY<STRING>` types to `STRING` might fail, but there is a descriptive error message and the fix is pretty easy. #### Release note MSQ ingestion context flag `arrayIngestMode` now defaults to `array` instead of `mvd`. This means that SQL `VARCHAR ARRAY` types will no longer be implicitly translated and stored into `VARCHAR` columns, but will instead be stored as `VARCHAR ARRAY`. To store multi-value strings modify any insert/replace queries to wrap the array types with the `ARRAY_TO_MV` operator. Validation is in place that will prevent mixing `VARCHAR` and `VARCHAR ARRAY` columns in the same table, so any ingestions affected by this change will fail and provide a descriptive error message instead of silently doing something unexpected. See https://druid.apache.org/docs/latest/querying/multi-value-dimensions#sql-based-ingestion for additional information about how to ingest multi-value strings, and https://druid.apache.org/docs/latest/querying/arrays#sql-based-ingestion for additional information about arrays. <hr> This PR has: - [x] been self-reviewed. - [x] added documentation for new or modified features or behaviors. - [x] a release note entry in the PR description. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
