gargvishesh commented on code in PR #16778:
URL: https://github.com/apache/druid/pull/16778#discussion_r1692450243
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -1553,7 +1557,7 @@ private void handleQueryResults(
Tasks.DEFAULT_STORE_COMPACTION_STATE
);
- if (!segments.isEmpty() && storeCompactionState) {
Review Comment:
Earlier tombstone segments weren't annotated with `CompactionState`. Esp in
case of empty content segments (but tombstones present), the `ShardSpec` wasn't
available to do so. Now if there are no generated segments, we infer the
ShardSpec from the `MSQControllerTask` spec and use that to annotate the state
to tombstones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
