techdocsmith commented on code in PR #16812: URL: https://github.com/apache/druid/pull/16812#discussion_r1697383097
########## docs/querying/sql-functions.md: ########## @@ -605,11 +605,34 @@ Returns the rank for a row within a window without gaps. For example, if two row ## DIV -`DIV(x, y)` +Returns the result of integer division of `x` by `y`. -**Function type:** [Scalar, numeric](sql-scalar.md#numeric-functions) +* **Syntax:** `DIV(x, y)` +* **Function type:** Scalar, numeric -Returns the result of integer division of `x` by `y`. +<details><summary>Example</summary> + + The following calculates integer divisions of `78` by `10`. + + ```sql + SELECT DIV(78, 10) as "division" + ``` + + Returns the following: + + | `division` | + | -- | + | `7` | + +</details> Review Comment: Comment out the docs (`<!-- -->`) for this function. It is false until Druid 31. We can fix it closer to the release. ########## docs/querying/sql-functions.md: ########## @@ -605,11 +605,34 @@ Returns the rank for a row within a window without gaps. For example, if two row ## DIV -`DIV(x, y)` +Returns the result of integer division of `x` by `y`. -**Function type:** [Scalar, numeric](sql-scalar.md#numeric-functions) +* **Syntax:** `DIV(x, y)` +* **Function type:** Scalar, numeric -Returns the result of integer division of `x` by `y`. +<details><summary>Example</summary> + + The following calculates integer divisions of `78` by `10`. + + ```sql + SELECT DIV(78, 10) as "division" + ``` + + Returns the following: + + | `division` | + | -- | + | `7` | + +</details> Review Comment: Keep the admonition. ########## docs/querying/sql-functions.md: ########## @@ -866,28 +889,78 @@ Returns a union of HLL sketches. ## HUMAN_READABLE_BINARY_BYTE_FORMAT -`HUMAN_READABLE_BINARY_BYTE_FORMAT(value[, precision])` +Converts an integer byte size into human-readable [IEC](https://en.wikipedia.org/wiki/Binary_prefix) format. -**Function type:** [Scalar, numeric](sql-scalar.md#numeric-functions) +* **Syntax:** `HUMAN_READABLE_BINARY_BYTE_FORMAT(value[, precision])` +* **Function type:** Scalar, numeric + +<details><summary>Example</summary> + + Converts `1000000` into IEC format. Review Comment: ```suggestion The following converts `1000000` into IEC format. ``` Retain "the following for consistency" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
