clintropolis commented on code in PR #16825:
URL: https://github.com/apache/druid/pull/16825#discussion_r1699768785
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQComplexGroupByTest.java:
##########
@@ -416,4 +432,91 @@ public void testSortingOnNestedData(String contextName,
Map<String, Object> cont
))
.verifyResults();
}
+
+ @MethodSource("data")
+ @ParameterizedTest(name = "{index}:with context {0}")
+ public void testCountDistinctOnNestedData(String contextName, Map<String,
Object> context)
Review Comment:
Should probably add to the test name that this is an exact distinct since
the approximate aggs don't work with complex types yet afaik.
it might be interesting to also add a test where every row is not unique,
such as the `cObj` column in this same file, though i suppose that is the other
extreme...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
