abhishekrb19 commented on code in PR #16822:
URL: https://github.com/apache/druid/pull/16822#discussion_r1702379963
##########
processing/src/main/java/org/apache/druid/guice/BuiltInTypesModule.java:
##########
@@ -53,14 +61,15 @@ public List<? extends Module> getJacksonModules()
public void configure(Binder binder)
{
registerSerde();
- // binding our side effect class to the lifecycle causes registerHandler
to be called on service start, allowing
- // use of the config to get the system default format version
- LifecycleModule.register(binder, SideEffectHandlerRegisterer.class);
+ // binding our side effect classes to the lifecycle causes the
initDimensionHandlerAndMvHandlingMode to be
+ // called on service start, allowing use of the config to get the system
default format version and string multi
+ // value handling mode.
+ LifecycleModule.register(binder, SideEffectRegisterer.class);
}
@Provides
@LazySingleton
- public SideEffectHandlerRegisterer registerHandler(DefaultColumnFormatConfig
formatsConfig)
+ public static SideEffectRegisterer
initDimensionHandlerAndMvHandlingMode(DefaultColumnFormatConfig formatsConfig)
Review Comment:
Ah, that's because there was a findbugs error in the build for the
assignment of `STRING_MV_MODE` :
```
'write to static field from instance method'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
