adarshsanjeev commented on PR #16804: URL: https://github.com/apache/druid/pull/16804#issuecomment-2272702612
@Akshat-Jain, could you make a follow up PR to handle this: https://github.com/apache/druid/pull/16804/files#r1700096766? Essentially, perhaps we should have a separate org.apache.druid.msq.querykit.DataSourcePlan#forQuery, which passes a result shuffle spec factory which encapsulates the logic of choosing the shuffle spec. We could then change the overriding of shuffle spec to a validation exception instead. cc: @cryptoe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
