gargvishesh opened a new pull request, #16987: URL: https://github.com/apache/druid/pull/16987
### Description MSQ only supports `rowsPerSegment` as part of its tuning config. When compaction with MSQ engine finally creates the `lastCompactionState`, the same value is persisted as `targetRowsPerSegment` in `DimensionRangePartitionsSpec`, and `maxRowsPerSegment` is set to `null`. This PR invalidates compaction configs with `DimensionRangePartitionsSpec` containing `maxRowsPerSegment`, as otherwise it would lead to repeated compactions resulting from mismatch between actual and expected `lastCompactionState`-- since actual would have `maxRowsPerSegment` always set to `null`. - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [x] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
