github-advanced-security[bot] commented on code in PR #17178:
URL: https://github.com/apache/druid/pull/17178#discussion_r1778965934
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesOverlordModule.java:
##########
@@ -162,6 +176,70 @@
: injector.getInstance(RemoteTaskRunnerFactory.class);
}
+ /**
+ * Provides a TaskAdapter instance for the KubernetesTaskRunner.
+ */
+ @Provides
+ @LazySingleton
+ TaskAdapter provideTaskAdapter(
+ DruidKubernetesClient client,
+ Properties properties,
+ KubernetesTaskRunnerConfig kubernetesTaskRunnerConfig,
+ TaskConfig taskConfig,
+ StartupLoggingConfig startupLoggingConfig,
+ @Self DruidNode druidNode,
+ @Smile ObjectMapper smileMapper,
+ TaskLogs taskLogs,
+ Supplier<KubernetesTaskRunnerDynamicConfig> dynamicConfigRef
+ )
+ {
+ String adapter = properties.getProperty(String.format(
+ Locale.ROOT,
+ "%s.%s.adapter.type",
+ IndexingServiceModuleHelper.INDEXER_RUNNER_PROPERTY_PREFIX,
+ "k8s"
+ ));
+
+ if (adapter != null && !MultiContainerTaskAdapter.TYPE.equals(adapter) &&
kubernetesTaskRunnerConfig.isSidecarSupport()) {
Review Comment:
## Deprecated method or constructor invocation
Invoking [KubernetesTaskRunnerConfig.isSidecarSupport](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/8359)
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesOverlordModule.java:
##########
@@ -162,6 +176,70 @@
: injector.getInstance(RemoteTaskRunnerFactory.class);
}
+ /**
+ * Provides a TaskAdapter instance for the KubernetesTaskRunner.
+ */
+ @Provides
+ @LazySingleton
+ TaskAdapter provideTaskAdapter(
+ DruidKubernetesClient client,
+ Properties properties,
+ KubernetesTaskRunnerConfig kubernetesTaskRunnerConfig,
+ TaskConfig taskConfig,
+ StartupLoggingConfig startupLoggingConfig,
+ @Self DruidNode druidNode,
+ @Smile ObjectMapper smileMapper,
+ TaskLogs taskLogs,
+ Supplier<KubernetesTaskRunnerDynamicConfig> dynamicConfigRef
+ )
+ {
+ String adapter = properties.getProperty(String.format(
+ Locale.ROOT,
+ "%s.%s.adapter.type",
+ IndexingServiceModuleHelper.INDEXER_RUNNER_PROPERTY_PREFIX,
+ "k8s"
+ ));
+
+ if (adapter != null && !MultiContainerTaskAdapter.TYPE.equals(adapter) &&
kubernetesTaskRunnerConfig.isSidecarSupport()) {
+ throw new IAE(
+ "Invalid pod adapter [%s], only pod adapter [%s] can be specified
when sidecarSupport is enabled",
+ adapter,
+ MultiContainerTaskAdapter.TYPE
+ );
+ }
+
+ if (MultiContainerTaskAdapter.TYPE.equals(adapter) ||
kubernetesTaskRunnerConfig.isSidecarSupport()) {
Review Comment:
## Deprecated method or constructor invocation
Invoking [KubernetesTaskRunnerConfig.isSidecarSupport](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/8360)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
