zachjsh commented on code in PR #17355:
URL: https://github.com/apache/druid/pull/17355#discussion_r1802091168
##########
extensions-core/kafka-extraction-namespace/pom.xml:
##########
@@ -67,6 +67,18 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>software.amazon.msk</groupId>
+ <artifactId>aws-msk-iam-auth</artifactId>
Review Comment:
we need to provide a uber jar here. If we dont exclude the dependencies as
we're doing here, we could clobber other dependencies we are currently using in
the extension. and excluding as we're doing here, will likely cause issue as
well, as needed dependencies will be missing. AWS produces an uber jar here:
https://github.com/aws/aws-msk-iam-auth/releases/download/v1.1.5/aws-msk-iam-auth-1.1.5-all.jar.
But this is not available on the maven repo that this project uses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
