cryptoe commented on code in PR #17443:
URL: https://github.com/apache/druid/pull/17443#discussion_r1832101616
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/DataSourcePlan.java:
##########
@@ -413,15 +418,25 @@ private static DataSourcePlan forLookup(
private static DataSourcePlan forQuery(
final QueryKitSpec queryKitSpec,
final QueryDataSource dataSource,
+ final QueryContext queryContext,
Review Comment:
Why is query context required ?
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/MultiStageQueryContext.java:
##########
@@ -191,6 +191,8 @@ public class MultiStageQueryContext
public static final String MAX_ROWS_MATERIALIZED_IN_WINDOW =
"maxRowsMaterializedInWindow";
+ public static final String WINDOW_FUNCTION_OPERATOR_TRANSFORMATION =
"windowFunctionOperatorTransformation";
Review Comment:
Could you please add a dev note here mentioning this flag can be removed in
druid 33 and will be always enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
