ektravel commented on code in PR #17501:
URL: https://github.com/apache/druid/pull/17501#discussion_r1859281939


##########
docs/multi-stage-query/reference.md:
##########
@@ -146,25 +149,26 @@ FROM <table>
 
 Supported arguments for the function:
 
-| Parameter   | Required | Description                                         
                                                                                
                                                                                
                                                           | Default |
-|-------------|----------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------|
-| `bucket`    | Yes      | The S3 bucket to which the files are exported to. 
The bucket and prefix combination should be whitelisted in 
`druid.export.storage.s3.allowedExportPaths`.                                   
                                                                                
  | n/a     |
-| `prefix`    | Yes      | Path where the exported files would be created. The 
export query expects the destination to be empty. If the location includes 
other files, then the query will fail. The bucket and prefix combination should 
be whitelisted in `druid.export.storage.s3.allowedExportPaths`. | n/a     |
+| Parameter | Required | Description | Default |
+|---|---|---|---|
+| `bucket` | Yes  | S3 bucket destination for exported files. You must add the 
bucket and prefix combination to the 
`druid.export.storage.s3.allowedExportPaths` allow list. | n/a |
+| `prefix` | Yes  | Destination path in the bucket to create exported files. 
The export query expects the destination path to be empty. If the location 
includes other files, the query will fail. You must add the bucket and prefix 
combination to the `druid.export.storage.s3.allowedExportPaths` allow list. | 
n/a |
 
-The following runtime parameters must be configured to export into an S3 
destination:
+Configure following runtime parameters to export to an S3 destination:

Review Comment:
   ```suggestion
   Configure the following runtime parameters to export to an S3 destination:
   ```



##########
docs/multi-stage-query/reference.md:
##########
@@ -128,10 +127,14 @@ SELECT
 FROM <table>
 ```
 
-##### S3
+##### S3 - Amazon S3
+
+To export results to S3, pass the `s3()` function as an argument to the 
`EXTERN` function.
+Export to S3 requires the `druid-s3-extensions` extension

Review Comment:
   ```suggestion
   Export to S3 requires the `druid-s3-extensions` extension.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to