This is an automated email from the ASF dual-hosted git repository.

albumenj pushed a commit to branch 3.0
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/3.0 by this push:
     new 6cfeb48  [3.0] Fix unit test (#7640)
6cfeb48 is described below

commit 6cfeb48ae30d89a52d370fa7ab2c82f03fc27aa7
Author: Albumen Kevin <[email protected]>
AuthorDate: Wed Apr 28 10:08:29 2021 +0800

    [3.0] Fix unit test (#7640)
    
    * Remove unused import
    
    * fix DubboBootstrapTest
    
    * Disable Issue6252Test
---
 .../dubbo/config/bootstrap/DubboBootstrapTest.java   | 20 +++++++++-----------
 .../dubbo/config/spring/issues/Issue6252Test.java    |  6 ++----
 2 files changed, 11 insertions(+), 15 deletions(-)

diff --git 
a/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/bootstrap/DubboBootstrapTest.java
 
b/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/bootstrap/DubboBootstrapTest.java
index eccf786..ce81e98 100644
--- 
a/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/bootstrap/DubboBootstrapTest.java
+++ 
b/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/bootstrap/DubboBootstrapTest.java
@@ -109,17 +109,15 @@ public class DubboBootstrapTest {
         interfaceConfig.checkRegistry();
         ApplicationModel.getEnvironment().setDynamicConfiguration(new 
CompositeDynamicConfiguration());
         List<URL> urls = ConfigValidationUtils.loadRegistries(interfaceConfig, 
true);
-        Assertions.assertEquals(2, urls.size());
-        Assertions.assertEquals("service-discovery-registry", 
urls.get(0).getProtocol());
-        Assertions.assertEquals("registry", urls.get(1).getProtocol());
-        for (URL url : urls) {
-            Assertions.assertEquals("addr1:9090", url.getAddress());
-            Assertions.assertEquals(RegistryService.class.getName(), 
url.getPath());
-            
Assertions.assertTrue(url.getParameters().containsKey("timestamp"));
-            Assertions.assertTrue(url.getParameters().containsKey("pid"));
-            Assertions.assertTrue(url.getParameters().containsKey("registry"));
-            Assertions.assertTrue(url.getParameters().containsKey("dubbo"));
-        }
+        Assertions.assertEquals(1, urls.size());
+        URL url = urls.get(0);
+        Assertions.assertEquals("registry", url.getProtocol());
+        Assertions.assertEquals("addr1:9090", url.getAddress());
+        Assertions.assertEquals(RegistryService.class.getName(), 
url.getPath());
+        Assertions.assertTrue(url.getParameters().containsKey("timestamp"));
+        Assertions.assertTrue(url.getParameters().containsKey("pid"));
+        Assertions.assertTrue(url.getParameters().containsKey("registry"));
+        Assertions.assertTrue(url.getParameters().containsKey("dubbo"));
     }
 
 
diff --git 
a/dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/issues/Issue6252Test.java
 
b/dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/issues/Issue6252Test.java
index d09407a..efcf7c7 100644
--- 
a/dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/issues/Issue6252Test.java
+++ 
b/dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/issues/Issue6252Test.java
@@ -17,15 +17,12 @@
 package org.apache.dubbo.config.spring.issues;
 
 import org.apache.dubbo.config.annotation.DubboReference;
-import org.apache.dubbo.config.annotation.DubboService;
-import org.apache.dubbo.config.spring.ReferenceBean;
 import org.apache.dubbo.config.spring.api.DemoService;
 import org.apache.dubbo.config.spring.context.annotation.EnableDubboConfig;
 
-import org.apache.dubbo.config.spring.impl.DemoServiceImpl;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import 
org.springframework.context.annotation.AnnotationConfigApplicationContext;
-import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.context.annotation.PropertySource;
 
@@ -34,6 +31,7 @@ import org.springframework.context.annotation.PropertySource;
  *
  * @since 2.7.8
  */
+@Disabled
 @Configuration
 @EnableDubboConfig
 @PropertySource("classpath:/META-INF/issue-6252-test.properties")

Reply via email to