This is an automated email from the ASF dual-hosted git repository.
liujun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git
The following commit(s) were added to refs/heads/master by this push:
new 028153a Update Pull Request Template (#7828)
028153a is described below
commit 028153a19940d7a5f2d78d415c3cf5f93fdb8543
Author: Albumen Kevin <[email protected]>
AuthorDate: Mon May 24 10:28:45 2021 +0800
Update Pull Request Template (#7828)
---
PULL_REQUEST_TEMPLATE.md | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md
index a1384f2..e924748 100644
--- a/PULL_REQUEST_TEMPLATE.md
+++ b/PULL_REQUEST_TEMPLATE.md
@@ -10,9 +10,12 @@
<!-- Follow this checklist to help us incorporate your contribution quickly
and easily: -->
+## Checklist
- [x] Make sure there is a
[GitHub_issue](https://github.com/apache/dubbo/issues) field for the change
(usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue,
without pulling in other changes - one PR resolves one issue.
-- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException
when host config not exist #XXX`. Each commit in the pull request should have a
meaningful subject line and body.
+- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
+- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a
little better when cross module dependency exist. If the new feature or
significant change is committed, please remember to add sample in [dubbo
samples](https://github.com/apache/dubbo-samples) project.
-- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile
failsafe:integration-test` to make sure unit-test and integration-test pass.
+- [ ] Add some description to
[dubbo-website](https://github.com/apache/dubbo-website) project if you are
requesting to add a feature.
+- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation
Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
