This is an automated email from the ASF dual-hosted git repository.

albumenj pushed a commit to branch 3.0
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/3.0 by this push:
     new 3339e88  fix @test annotation (#9596)
3339e88 is described below

commit 3339e88823766faaeaddd11ff4965f181746dfb1
Author: Wang Chengming <[email protected]>
AuthorDate: Sun Jan 23 17:04:40 2022 +0800

    fix @test annotation (#9596)
---
 .../rpc/cluster/support/AbstractClusterInvokerTest.java    |  2 +-
 .../rpc/cluster/support/AvailableClusterInvokerTest.java   |  4 ++--
 .../rpc/cluster/support/FailSafeClusterInvokerTest.java    |  4 ++--
 .../rpc/cluster/support/FailfastClusterInvokerTest.java    |  4 ++--
 .../rpc/cluster/support/FailoverClusterInvokerTest.java    | 14 +++++++-------
 .../rpc/cluster/support/ForkingClusterInvokerTest.java     |  4 ++--
 6 files changed, 16 insertions(+), 16 deletions(-)

diff --git 
a/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/AbstractClusterInvokerTest.java
 
b/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/AbstractClusterInvokerTest.java
index c3bff9f..beb2f90 100644
--- 
a/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/AbstractClusterInvokerTest.java
+++ 
b/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/AbstractClusterInvokerTest.java
@@ -499,7 +499,7 @@ public class AbstractClusterInvokerTest {
         dic.buildRouterChain();
     }
 
-    @Test()
+    @Test
     public void testTimeoutExceptionCode() {
         List<Invoker<DemoService>> invokers = new 
ArrayList<Invoker<DemoService>>();
         invokers.add(new Invoker<DemoService>() {
diff --git 
a/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/AvailableClusterInvokerTest.java
 
b/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/AvailableClusterInvokerTest.java
index e254d73..6fe8247 100644
--- 
a/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/AvailableClusterInvokerTest.java
+++ 
b/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/AvailableClusterInvokerTest.java
@@ -86,7 +86,7 @@ public class AvailableClusterInvokerTest {
         
given(invoker3.getInterface()).willReturn(AvailableClusterInvokerTest.class);
     }
 
-    @Test()
+    @Test
     public void testInvokeNoException() {
 
         resetInvokerToNoException();
@@ -96,7 +96,7 @@ public class AvailableClusterInvokerTest {
         Assertions.assertSame(result, ret);
     }
 
-    @Test()
+    @Test
     public void testInvokeWithException() {
 
         // remove invokers for test exception
diff --git 
a/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/FailSafeClusterInvokerTest.java
 
b/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/FailSafeClusterInvokerTest.java
index c6f45c6..b8fb6c7 100644
--- 
a/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/FailSafeClusterInvokerTest.java
+++ 
b/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/FailSafeClusterInvokerTest.java
@@ -89,7 +89,7 @@ public class FailSafeClusterInvokerTest {
         Assertions.assertNull(RpcContext.getServiceContext().getInvoker());
     }
 
-    @Test()
+    @Test
     public void testInvokeNoExceptoin() {
 
         resetInvokerToNoException();
@@ -99,7 +99,7 @@ public class FailSafeClusterInvokerTest {
         Assertions.assertSame(result, ret);
     }
 
-    @Test()
+    @Test
     public void testNoInvoke() {
         dic = mock(Directory.class);
 
diff --git 
a/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/FailfastClusterInvokerTest.java
 
b/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/FailfastClusterInvokerTest.java
index 1b9c691..ae6f3c8 100644
--- 
a/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/FailfastClusterInvokerTest.java
+++ 
b/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/FailfastClusterInvokerTest.java
@@ -108,7 +108,7 @@ public class FailfastClusterInvokerTest {
         }
     }
 
-    @Test()
+    @Test
     public void testInvokeNoException() {
 
         resetInvoker1ToNoException();
@@ -118,7 +118,7 @@ public class FailfastClusterInvokerTest {
         assertSame(result, ret);
     }
 
-    @Test()
+    @Test
     public void testNoInvoke() {
         dic = mock(Directory.class);
 
diff --git 
a/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/FailoverClusterInvokerTest.java
 
b/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/FailoverClusterInvokerTest.java
index 1fd4075..6d906fa 100644
--- 
a/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/FailoverClusterInvokerTest.java
+++ 
b/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/FailoverClusterInvokerTest.java
@@ -101,7 +101,7 @@ public class FailoverClusterInvokerTest {
         }
     }
 
-    @Test()
+    @Test
     public void testInvokeWithRPCException() {
         given(invoker1.invoke(invocation)).willThrow(new RpcException());
         given(invoker1.isAvailable()).willReturn(true);
@@ -120,7 +120,7 @@ public class FailoverClusterInvokerTest {
         }
     }
 
-    @Test()
+    @Test
     public void testInvoke_retryTimes() {
         given(invoker1.invoke(invocation)).willThrow(new 
RpcException(RpcException.TIMEOUT_EXCEPTION));
         given(invoker1.isAvailable()).willReturn(false);
@@ -143,7 +143,7 @@ public class FailoverClusterInvokerTest {
         }
     }
 
-    @Test()
+    @Test
     public void testInvoke_retryTimes2() {
         int finalRetries = 1;
         given(invoker1.invoke(invocation)).willThrow(new 
RpcException(RpcException.TIMEOUT_EXCEPTION));
@@ -170,7 +170,7 @@ public class FailoverClusterInvokerTest {
         }
     }
 
-    @Test()
+    @Test
     public void testInvoke_retryTimes_withBizException() {
         given(invoker1.invoke(invocation)).willThrow(new 
RpcException(RpcException.BIZ_EXCEPTION));
         given(invoker1.isAvailable()).willReturn(false);
@@ -192,7 +192,7 @@ public class FailoverClusterInvokerTest {
         }
     }
 
-    @Test()
+    @Test
     public void testInvoke_without_retry() {
         int withoutRetry = 0;
         final URL url = URL.valueOf("test://localhost/" + Demo.class.getName() 
+ "?loadbalance=roundrobin&retries=" + withoutRetry);
@@ -219,7 +219,7 @@ public class FailoverClusterInvokerTest {
         }
     }
 
-    @Test()
+    @Test
     public void testInvoke_when_retry_illegal() {
         int illegalRetry = -1;
         final URL url = URL.valueOf("test://localhost/" + Demo.class.getName() 
+ "?loadbalance=roundrobin&retries=" + illegalRetry);
@@ -246,7 +246,7 @@ public class FailoverClusterInvokerTest {
         }
     }
 
-    @Test()
+    @Test
     public void testNoInvoke() {
         dic = mock(Directory.class);
 
diff --git 
a/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/ForkingClusterInvokerTest.java
 
b/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/ForkingClusterInvokerTest.java
index e00092d..fa5b714 100644
--- 
a/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/ForkingClusterInvokerTest.java
+++ 
b/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/support/ForkingClusterInvokerTest.java
@@ -141,7 +141,7 @@ public class ForkingClusterInvokerTest {
         Assertions.assertTrue(afterInvoke != null && afterInvoke.size() == 0, 
"clear attachment failed!");
     }
 
-    @Test()
+    @Test
     public void testInvokeNoException() {
 
         resetInvokerToNoException();
@@ -151,7 +151,7 @@ public class ForkingClusterInvokerTest {
         Assertions.assertSame(result, ret);
     }
 
-    @Test()
+    @Test
     public void testInvokeWithIllegalForksParam() {
         URL url = URL.valueOf("test://test:11/test?forks=-1");
         given(dic.getUrl()).willReturn(url);

Reply via email to