This is an automated email from the ASF dual-hosted git repository.
liujun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-kubernetes.git
The following commit(s) were added to refs/heads/master by this push:
new 8941644 update template
new 1a6f4b4 Merge pull request #36 from chickenlj/issue-template
8941644 is described below
commit 8941644c999851cc6b1f10bbfa44ce5c18e9aa38
Author: chickenlj <[email protected]>
AuthorDate: Sat Sep 16 21:08:43 2023 +0800
update template
---
...e.md => dubbo-kube-feature-request-template.md} | 6 ++---
...late.md => dubbo-kube-issue-report-template.md} | 14 +++++-----
.github/PULL_REQUEST_TEMPLATE.md | 13 +---------
.run/Admin.run.xml | 30 ----------------------
4 files changed, 11 insertions(+), 52 deletions(-)
diff --git a/.github/ISSUE_TEMPLATE/dubbo-admin-feature-request-template.md
b/.github/ISSUE_TEMPLATE/dubbo-kube-feature-request-template.md
similarity index 75%
rename from .github/ISSUE_TEMPLATE/dubbo-admin-feature-request-template.md
rename to .github/ISSUE_TEMPLATE/dubbo-kube-feature-request-template.md
index bdf74cb..6983738 100644
--- a/.github/ISSUE_TEMPLATE/dubbo-admin-feature-request-template.md
+++ b/.github/ISSUE_TEMPLATE/dubbo-kube-feature-request-template.md
@@ -1,11 +1,11 @@
---
-name: Dubbo-Admin feature request template
-about: If you would like to request a feature to Dubbo-Admin, please use this
template.
+name: dubbo-kube feature request template
+about: If you would like to request a feature to dubbo-kube, please use this
template.
---
- [ ] I have searched the
[issues](https://github.com/apache/dubbo-kubernetes/issues) of this repository
and believe that this is not a duplicate.
-- [ ] I have checked the
[REAMDE](https://github.com/apache/dubbo-kubernetes/blob/develop/README.md) of
this repository and believe that this is not a duplicate.
+- [ ] I have checked the
[REAMDE](https://github.com/apache/dubbo-kubernetes/blob/master/README.md) of
this repository and believe that this is not a duplicate.
### Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always
frustrated when [...]
diff --git a/.github/ISSUE_TEMPLATE/dubbo-admin-issue-report-template.md
b/.github/ISSUE_TEMPLATE/dubbo-kube-issue-report-template.md
similarity index 60%
rename from .github/ISSUE_TEMPLATE/dubbo-admin-issue-report-template.md
rename to .github/ISSUE_TEMPLATE/dubbo-kube-issue-report-template.md
index 5c946c8..9682f37 100644
--- a/.github/ISSUE_TEMPLATE/dubbo-admin-issue-report-template.md
+++ b/.github/ISSUE_TEMPLATE/dubbo-kube-issue-report-template.md
@@ -1,18 +1,18 @@
---
-name: Dubbo-Admin issue report template
-about: If you would like to report a issue to Dubbo-Admin, please use this
template.
+name: dubbo-kube issue report template
+about: If you would like to report a issue to dubbo-kube, please use this
template.
---
- [ ] I have searched the
[issues](https://github.com/apache/dubbo-kubernetes/issues) of this repository
and believe that this is not a duplicate.
-- [ ] I have checked the
[REAMDE](https://github.com/apache/dubbo-kubernetes/blob/develop/README.md) of
this repository and believe that this is not a duplicate.
+- [ ] I have checked the
[REAMDE](https://github.com/apache/dubbo-kubernetes/blob/master/README.md) of
this repository and believe that this is not a duplicate.
### Environment
-* Dubbo Admin version: xxx
-* Registry center detail (type and version): xxx
+* dubboctl or control-plane version: xxx
* Operating System version: xxx
-* Java version: xxx
+* Go version: xxx
+* Other information: xxx
### Steps to reproduce this issue
@@ -24,7 +24,7 @@ Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
-What do you expected from the above steps？
+What do you expect from the above steps？
### Actual Result
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 291f0f9..43b6c57 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -2,18 +2,7 @@
XXXXX
-## Brief changelog
-
-XX
-
-## Verifying this change
+## How to verify this change
XXXX
-Follow this checklist to help us incorporate your contribution quickly and
easily:
-
-* [ ] Make sure there is a Github issue filed for the change (usually before
you start working on it). Trivial changes like typos do not require a Github
issue. Your pull request should address just this issue, without pulling in
other changes - one PR resolves one issue.
-* [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException
when host config not exist`. Each commit in the pull request should have a
meaningful subject line and body.
-* [ ] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
-* [ ] Write necessary unit-test to verify your logic correction, more mock a
little better when cross module dependency exist.
-* [ ] Run `mvn clean compile --batch-mode -DskipTests=false
-Dcheckstyle.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true to make sure
basic checks pass.
diff --git a/.run/Admin.run.xml b/.run/Admin.run.xml
deleted file mode 100644
index 86728bb..0000000
--- a/.run/Admin.run.xml
+++ /dev/null
@@ -1,30 +0,0 @@
-<!--
- ~ Licensed to the Apache Software Foundation (ASF) under one or more
- ~ contributor license agreements. See the NOTICE file distributed with
- ~ this work for additional information regarding copyright ownership.
- ~ The ASF licenses this file to You under the Apache License, Version 2.0
- ~ (the "License"); you may not use this file except in compliance with
- ~ the License. You may obtain a copy of the License at
- ~
- ~ http://www.apache.org/licenses/LICENSE-2.0
- ~
- ~ Unless required by applicable law or agreed to in writing, software
- ~ distributed under the License is distributed on an "AS IS" BASIS,
- ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- ~ See the License for the specific language governing permissions and
- ~ limitations under the License.
--->
-<component name="ProjectRunConfigurationManager">
- <configuration default="false" name="Admin"
type="GoApplicationRunConfiguration" factoryName="Go Application">
- <module name="dubbo-admin" />
- <working_directory value="$PROJECT_DIR$" />
- <envs>
- <env name="ADMIN_CONFIG_PATH" value="conf/admin.yml" />
- </envs>
- <kind value="PACKAGE" />
- <package value="github.com/apache/dubbo-kubernetes/cmd/admin" />
- <directory value="$PROJECT_DIR$" />
- <filePath value="$PROJECT_DIR$/cmd/admin/main.go" />
- <method v="2" />
- </configuration>
-</component>
\ No newline at end of file
