100pah commented on a change in pull request #11283: Add clip option for line,
bar, lines, scatter, custom series
URL:
https://github.com/apache/incubator-echarts/pull/11283#discussion_r326124588
##########
File path: src/chart/bar/BarView.js
##########
@@ -158,6 +187,17 @@ export default echarts.extendChartView({
_renderLarge: function (seriesModel, ecModel, api) {
this._clear();
createLarge(seriesModel, this.group);
+
+ // Use clipPath in large mode.
+ var clipPath = seriesModel.get('clip', true)
+ ? createClipPath(seriesModel.coordinateSystem, false, seriesModel)
+ : null;
+ if (clipPath) {
+ this.group.setClipPath(clipPath);
+ }
+ else {
+ this.group.removeClipPath(null);
Review comment:
`null` is not needed.
It seems that `removeClipPath` has no arg.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
