foolzhang commented on a change in pull request #11557: feat(polar) about ISSUE
11452
URL:
https://github.com/apache/incubator-echarts/pull/11557#discussion_r348857766
##########
File path: src/chart/bar/BarView.js
##########
@@ -424,8 +425,9 @@ function updateStyle(
el.useStyle(zrUtil.defaults(
{
- fill: layout.startAngle === layout.endAngle ? 'transparent' :
color,
- opacity: layout.startAngle === layout.endAngle ? 0 : opacity
+ stroke : layout.startAngle === layout.endAngle ? 'none' : stroke,
+ fill: layout.startAngle === layout.endAngle ? 'none' : color,
+ opacity: opacity
Review comment:
> We should always update all to avoid the status leaking from previous
update.
reasonable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
