100pah commented on issue #12229: Crashing Safari and reload page URL: https://github.com/apache/incubator-echarts/issues/12229#issuecomment-596081503 The reason of this issue: When the `animation` is enabled (by default) and add data item to a line chart, the coordinate of the new added data item will be calculated based on the old coordinate system, and the result coordinate will be used as the begin point of the animation. See <https://github.com/apache/incubator-echarts/blob/4.6.0/src/chart/line/lineAnimationDiff.js#L121> See the demo code I give above, when there is only one data in the chart, the Y extent might be only be `[0, 1]`. When add a new data item `3547546` to the chart, the coordinate based on the previous Y extent `[0, 1]` is `-993312512`, which is a huge number. Even so, in most cases it works normally. But if we use both `createLinearGradient` and `shadow` in Safari with that huge size, the browser have a chance to crash. @pissang Do you have any idea about it? Limit the result of the "previous coord calculation"?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
