This is an automated email from the ASF dual-hosted git repository.

sushuang pushed a commit to branch fix/timeline-symbol
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git

commit 06efb46f7786ba0cea037d1dd758353298cf5703
Author: 100pah <sushuang0...@gmail.com>
AuthorDate: Mon Nov 9 13:07:28 2020 +0800

    fix: fix timeline tick symbol displayed at wrong place.
---
 src/component/timeline/SliderTimelineView.ts | 3 ++-
 test/timeline-layout.html                    | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/component/timeline/SliderTimelineView.ts 
b/src/component/timeline/SliderTimelineView.ts
index f8a5bc8..70f786e 100644
--- a/src/component/timeline/SliderTimelineView.ts
+++ b/src/component/timeline/SliderTimelineView.ts
@@ -430,7 +430,8 @@ class SliderTimelineView extends TimelineView {
             const progressStyleModel = itemModel.getModel(['progress', 
'itemStyle']);
 
             const symbolOpt = {
-                position: [tickCoord, 0],
+                x: tickCoord,
+                y: 0,
                 onclick: bind(this._changeTimeline, this, tick.value)
             };
             const el = giveSymbol(itemModel, itemStyleModel, group, symbolOpt);
diff --git a/test/timeline-layout.html b/test/timeline-layout.html
index 805ff89..f19bcd5 100644
--- a/test/timeline-layout.html
+++ b/test/timeline-layout.html
@@ -73,7 +73,7 @@ under the License.
                     timeline: {
                         inverse: true,
                         symbol: 'path://M0,0L10,0L10,10L0,10L0,0z',
-                        symbolSize: [1, 6],
+                        symbolSize: [10, 6],
                         symbolOffset: [0, 3],
                         symbolRotate: 30
                     }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org

Reply via email to