pissang edited a comment on pull request #14569: URL: https://github.com/apache/echarts/pull/14569#issuecomment-826303142
Found some exists very old bad designs durging the review. Going to fix it in a separate PR For example: The second parameter View#dataToPoint and Geo#dataToPoint don't follow other coordinate systems, which is `clamp`. It's easy to pass wrong value. https://github.com/apache/echarts/blob/master/src/coord/View.ts#L271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
