pissang edited a comment on pull request #15601: URL: https://github.com/apache/echarts/pull/15601#issuecomment-930682983
The code looks good except some code style issues. But I think option `drawMode` can have another name. `drawMode` in echarts is more like `fill`, `stroke`, etc. We can use `centerMode` for example? BTW it will be better if we can have screenshots for both mode in this pull request description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
