pe-3 commented on PR #17461: URL: https://github.com/apache/echarts/pull/17461#issuecomment-1229369083
> To be honest, I don't like the idea of `dynamicHeight` from the perspect of data visualization because it may cause much misunderstanding. But I understand this may be a common requirement so we can provide this option. > > But `dynamicHeight` is not a good name because it does not tell how it works with _dynamic_. From the description, I understand that the height is relative to the data. So we should probably present this information in the name. > > #17566 suggests using the area of the shapes to represent the data. Although you don't have to implement this feature in your PR, you should probably better design the API to make that feature possible in future PRs. > > > FYI, pie series use [roseType](https://echarts.apache.org/en/option.html#series-pie.roseType), although I'm not sure if this is useful. I also find this attribute suboptimal，what about dyamicMode, and it's alternative values are `height` and `size`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
