Ovilia commented on code in PR #18436:
URL: https://github.com/apache/echarts/pull/18436#discussion_r1154083530
##########
src/component/tooltip/TooltipHTMLContent.ts:
##########
@@ -291,14 +291,21 @@ class TooltipHTMLContent {
(el as any).domBelongToZr = true;
this.el = el;
const zr = this._zr = api.getZr();
- const appendToBody = this._appendToBody = opt && opt.appendToBody;
- makeStyleCoord(this._styleCoord, zr, appendToBody, api.getWidth() / 2,
api.getHeight() / 2);
-
- if (appendToBody) {
- document.body.appendChild(el);
+ let customContainer: HTMLElement | null
+ if (opt && opt.appendToBody) {
+ customContainer = this._customContainer = document.body
+ } else if (opt && opt.getAppendElement) {
Review Comment:
@plainheart Thanks for the information about `teleport`, and yes I think it
should be better be in the tooltip option than `init`. As about the naming, I
thing `appendTo` is a better name and `appendToBody` can be replaced as
`appendTo: document.body` or `appendTo: 'body'` (using query selector).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
